From 098acc2a8670a7d0b5157574c5042f2b95294ca9 Mon Sep 17 00:00:00 2001 From: Huiyu Xie Date: Fri, 6 Dec 2024 19:06:00 -1000 Subject: [PATCH] Set version bounds for Trixi.jl to ensure compatibility (#86) * Fix Trixi version * Change README.md * Minor fix --- Project.toml | 4 +--- README.md | 2 ++ src/TrixiCUDA.jl | 8 ++++---- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/Project.toml b/Project.toml index 4607e89..bda7d26 100644 --- a/Project.toml +++ b/Project.toml @@ -9,15 +9,13 @@ CUDA = "052768ef-5323-5732-b1bb-66c8b64840ba" SciMLBase = "0bca4576-84f4-4d90-8ffe-ffa030f20462" StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" Trixi = "a7f1ee26-1774-49b1-8366-f1abc58fbfcb" -TrixiBase = "9a0f1c46-06d5-4909-a5a3-ce25d3fa3284" [compat] BenchmarkTools = "1" CUDA = "5" SciMLBase = "2" StaticArrays = "1" -Trixi = "0.8, 0.9" -TrixiBase = "0.1" +Trixi = "0.8, 0.9.8 - 0.9.8" julia = "1.10" [extras] diff --git a/README.md b/README.md index faa55d8..a9af1cb 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,8 @@ TrixiCUDA.jl offers CUDA acceleration for solving hyperbolic PDEs. +⚠️ **_Warning_**: Our package may not always be updated with the latest updates or improvements in Trixi.jl. Forcing an update of Trixi.jl as a dependency for TrixiCUDA.jl beyond the version bounds specified in `Project.toml` may cause unexpected errors. + *Update on Nov 21, 2024*: - Due to the [issue](https://github.com/trixi-framework/Trixi.jl/issues/2108) from upstream with Trixi.jl and CUDA.jl in Julia v1.11, this package now supports only Julia v1.10. Using or developing this package with Julia v1.11 will result in precompilation errors. To fix this, downgrade to Julia v1.10. If you have any other problems, please file issues [here](https://github.com/trixi-gpu/TrixiCUDA.jl/issues). diff --git a/src/TrixiCUDA.jl b/src/TrixiCUDA.jl index 40f3e7b..ad13e81 100644 --- a/src/TrixiCUDA.jl +++ b/src/TrixiCUDA.jl @@ -33,15 +33,15 @@ using SciMLBase: ODEProblem, FullSpecialize using StaticArrays: SVector +# Change to use the Base.log and Base.sqrt - need to be fixed to avoid outputs +set_log_type!("log_Base") +set_sqrt_type!("sqrt_Base") + # Include other source files include("auxiliary/auxiliary.jl") include("semidiscretization/semidiscretization.jl") include("solvers/solvers.jl") -# Change to use the Base.log and Base.sqrt - need to be fixed to avoid outputs -set_log_type!("log_Base") -set_sqrt_type!("sqrt_Base") - # Export the public APIs export SemidiscretizationHyperbolicGPU export semidiscretizeGPU