Repeated Conditional incorrectly reports in case there are local variable checks in different methods

[hwo411]

In case we have code like

class RepeatedConditionals
  def repeat_1
    switch = true # or some other code, e.g. `Service.call(...)`
    puts "Repeat 1!" if switch
  end

  def repeat_2
    switch = false # or some other code, e.g. `Service.call(...)`
    puts "Repeat 2!" if switch
  end

  def repeat_3
    switch = 123 # or some other code, e.g. `Service.call(...)`
    puts "Repeat 3!" if switch
  end
end

reek incorrectly reports Repeated Conditional

It shouldn't do this if all of the conditionals are local variables.

[troessner]

It shouldn't do this if all of the conditionals are local variables.

Fair point! That should be fairly easy to fix, thanks for the bug report.

[JuanVqz]

@troessner I'd like to help on this one. I wonder how should we fix it. Can we scope the if and case per def method? will it break the attr_accessor scenario? Thanks for any help/guide/idea you can provide.