Владислав Садыров #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Снежинка Коха
disturm
approved these changes
Mar 19, 2017
SK.js
Outdated
| context.fillRect(0, 0, 0, 0); | ||
| addEventListener("keydown", function(event) { | ||
| if (event.code == "Enter"){ | ||
| i=3; |
There was a problem hiding this comment.
Тебе не нужны глобальные переменные i, k, раз ты их в начале обработчика перетираешь. На самом деле глобальных переменных вообще следует избегать.
SK.js
Outdated
| context.clearRect(200, -2,-1000, 900); | ||
| context.fillRect(0, 0, 0, 0); | ||
| context.fillStyle = "red"; | ||
| while((i--)>0){ |
There was a problem hiding this comment.
Выделить этот цикл в отдельную функцию - правильная идея. Так ты отделишь хитрую логику обработки ошибок в пользовательском вводе от алгоритма. Читабельность повысится, возможность повторного использования кода (алгоритма) тоже. Да, здесь негде переиспользовать, но хорошие привычки надо вырабатывать
SK.js
Outdated
| function inRad(num) { | ||
| return num * Math.PI / 180; | ||
| } | ||
| function Coha(n, k){ |
There was a problem hiding this comment.
Названия функций должны быть глаголами
Исправленный
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Снежинка Коха