Merge pull request #269 from vsbogd/fix-arg-type-match-188-v2

Fix type matching for the function call arguments in case of parameterized function type
trueagi-io · Apr 11, 2023 · fc1ec1f · fc1ec1f
2 parents 8a58ba4 + ab03b7b
commit fc1ec1f
Show file tree

Hide file tree

Showing 4 changed files with 257 additions and 148 deletions.
diff --git a/lib/src/atom/mod.rs b/lib/src/atom/mod.rs
@@ -349,6 +349,7 @@ pub trait GroundedAtom : mopa::Any + Debug + Display {
     fn as_any_ref(&self) -> &dyn Any;
     fn as_any_mut(&mut self) -> &mut dyn Any;
 
+    // TODO: type_() should return Vec<Atom> because of type non-determinism
     fn type_(&self) -> Atom;
     fn execute(&self, args: &mut Vec<Atom>) -> Result<Vec<Atom>, ExecError>;
     fn match_(&self, other: &Atom) -> matcher::MatchResultIter;

diff --git a/lib/src/metta/mod.rs b/lib/src/metta/mod.rs
@@ -30,6 +30,7 @@ pub const INCORRECT_NUMBER_OF_ARGUMENTS_SYMBOL : Atom = sym!("IncorrectNumberOfA
 pub const NOT_REDUCIBLE_SYMBOL : Atom = sym!("NotReducible");
 pub const NO_VALID_ALTERNATIVES : Atom = sym!("NoValidAlternatives");
 
+// TODO: use stdlib to parse input text
 pub fn metta_space(text: &str) -> GroundingSpace {
     let tokenizer = common_tokenizer();
     let mut parser = SExprParser::new(text);
@@ -55,6 +56,7 @@ fn common_tokenizer() -> Tokenizer {
     tokenizer
 }
 
+// TODO: use stdlib to parse input text
 pub fn metta_atom(atom: &str) -> Atom {
     let tokenizer = common_tokenizer();
     let mut parser = SExprParser::new(atom);