Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-128390 / 25.04 / Adjust min child count when creating draid pools #11115

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

RehanY147
Copy link
Contributor

Changes:

Adjusts min allowed child count when creating dRaid pools

Testing:

The children select's minimum value when creating a draid pool should be calculated based on this formula

max = Math.min(maxAvailableDisks, 255)
parity = 1 if dRaid1, 2 if dRaid2, 3 if dRaid3
min = (data vdev disks) + (hot spares count) + parity

@RehanY147 RehanY147 requested a review from a team as a code owner November 28, 2024 21:16
@RehanY147 RehanY147 requested review from undsoft and removed request for a team November 28, 2024 21:16
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-128390: Adjust min child count when creating draid pools NAS-128390 / 25.04 / Adjust min child count when creating draid pools Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.29%. Comparing base (8c8c3c6) to head (5b9f8f2).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11115   +/-   ##
=======================================
  Coverage   82.28%   82.29%           
=======================================
  Files        1650     1650           
  Lines       57730    57729    -1     
  Branches     5948     5948           
=======================================
+ Hits        47506    47508    +2     
+ Misses      10224    10221    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to create a pool with more children now.

@RehanY147 RehanY147 merged commit 1261458 into master Nov 29, 2024
9 checks passed
@RehanY147 RehanY147 deleted the NAS-128390 branch November 29, 2024 21:23
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants