From 84323c3ce3ef7bbce1a62ad2aafcb1040770a773 Mon Sep 17 00:00:00 2001 From: Tyler Jang Date: Mon, 6 Nov 2023 15:13:06 -0800 Subject: [PATCH] Disable new tool tests on Windows (#550) Because of weirdness of node shims, we don't support this at the moment. Disable these tests. --- tools/gulp/gulp.test.ts | 4 ++++ tools/tailwindcss/tailwindcss.test.ts | 4 ++++ tools/webpack/webpack.test.ts | 4 ++++ 3 files changed, 12 insertions(+) diff --git a/tools/gulp/gulp.test.ts b/tools/gulp/gulp.test.ts index 6051028ed..5027df329 100644 --- a/tools/gulp/gulp.test.ts +++ b/tools/gulp/gulp.test.ts @@ -1,4 +1,5 @@ import { makeToolTestConfig, toolTest } from "tests"; +import { skipOS } from "tests/utils"; toolTest({ toolName: "gulp", @@ -9,4 +10,7 @@ toolTest({ expectedOut: "Local version: 4.0.2", }), ], + // On Windows, the shim is gulp.cmd, and we don't support platform-specific shims yet. + // To use on Windows, override the shim with gulp.cmd. + skipTestIf: skipOS(["win32"]), }); diff --git a/tools/tailwindcss/tailwindcss.test.ts b/tools/tailwindcss/tailwindcss.test.ts index 984ad6a4d..ac565fa5b 100644 --- a/tools/tailwindcss/tailwindcss.test.ts +++ b/tools/tailwindcss/tailwindcss.test.ts @@ -1,4 +1,5 @@ import { makeToolTestConfig, toolTest } from "tests"; +import { skipOS } from "tests/utils"; toolTest({ toolName: "tailwindcss", @@ -9,4 +10,7 @@ toolTest({ expectedOut: "tailwindcss v3.3.5", }), ], + // On Windows, the shim is tailwindcss.cmd, and we don't support platform-specific shims yet. + // To use on Windows, override the shim with tailwindcss.cmd. + skipTestIf: skipOS(["win32"]), }); diff --git a/tools/webpack/webpack.test.ts b/tools/webpack/webpack.test.ts index baf333b64..abf65f271 100644 --- a/tools/webpack/webpack.test.ts +++ b/tools/webpack/webpack.test.ts @@ -1,4 +1,5 @@ import { makeToolTestConfig, toolTest } from "tests"; +import { skipOS } from "tests/utils"; toolTest({ toolName: "webpack", @@ -9,4 +10,7 @@ toolTest({ expectedOut: "Binaries:", }), ], + // On Windows, the shim is webpack.cmd, and we don't support platform-specific shims yet. + // To use on Windows, override the shim with webpack.cmd. + skipTestIf: skipOS(["win32"]), });