Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if-change rule should not run on upstream. it only cares about current changes #54

Merged
merged 1 commit into from
Nov 11, 2024
Merged

if-change rule should not run on upstream. it only cares about current changes #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .trunk/trunk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ lint:
batch: true
success_codes: [0]
read_output_from: tmp_file
cache_results: true
disable_upstream: false
max_concurrency: 1
direct_configs: [toolbox.toml, log4rs.yaml]
Expand Down
5 changes: 5 additions & 0 deletions src/rules/if_change_then_change.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,11 @@ pub fn ictc(run: &Run, upstream: &str) -> anyhow::Result<Vec<diagnostic::Diagnos
return Ok(vec![]);
}

if run.is_upstream() {
trace!("'if-change' rule doesn't run on upstream");
return Ok(vec![]);
}

debug!(
"scanning {} files for if_change_then_change",
run.paths.len()
Expand Down
Loading