-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump littlefs version #7
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but not tested yet.
It's weird, it fails to compile for embedded targets because bindgen fails to find |
I can test this new bump. Does it require any changes on littlefs2 crate except patching the littlefs2-sys crate? Would be nice to update the littlefs version which it updates to in the Readme. |
I do get the
|
@@ -26,6 +26,7 @@ fn main() -> Result<(), Box<dyn std::error::Error>> { | |||
let bindings = bindgen::Builder::default() | |||
.header("littlefs/lfs.h") | |||
.clang_arg(format!("--target={}", target)) | |||
.clang_arg("-I/usr/arm-none-eabi/include") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be documented. I had a compiler just not at this location so I had to make a symlink ln -s
for this to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally I would prefer something that does not need that kind of hack and works even on weird distros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what are the options honestly as I'm not experienced with C/C++ but I'm happy to say that so far this version is working with my initial testing.
2afa881
to
71acedb
Compare
This should cause any backward compatibility issues, but we should be certain when we do this update, as rollbacks won't be possible.
For example if Nitrokey publishes a test release with this update, users would be able to roll back to a stable release without this change, which would make the filesystem unreadable.