Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace calling oidc cli with some code #22

Merged
merged 2 commits into from
Jul 25, 2024
Merged

refactor: replace calling oidc cli with some code #22

merged 2 commits into from
Jul 25, 2024

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Jul 25, 2024

No description provided.

@ctron ctron requested a review from JimFuller-RedHat July 25, 2024 12:00
JimFuller-RedHat
JimFuller-RedHat approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@JimFuller-RedHat JimFuller-RedHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... though this code is teaching me more then I know ;) glad this got done properly.

@helio-frota
Copy link
Contributor

Question: the readme needs updates ?

@ctron
Copy link
Contributor Author

ctron commented Jul 25, 2024

Question: the readme needs updates ?

good point! Did that too.

@helio-frota helio-frota self-requested a review July 25, 2024 12:42
@ctron ctron merged commit e7cfbaa into trustification:main Jul 25, 2024
1 check passed
@ctron ctron deleted the feature/oidc_provider_1 branch July 25, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helio-frota helio-frota helio-frota approved these changes

@JimFuller-RedHat JimFuller-RedHat JimFuller-RedHat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctron @helio-frota @JimFuller-RedHat