Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lmeval): Disallow empty nodeAffinity #369

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

tedhtchang
Copy link
Contributor

@tedhtchang tedhtchang commented Nov 26, 2024

  1. Resolves [Bug] Empty nodeSelectorTerm in Pod #368
  2. Add none nodeLabels example to README

Copy link

openshift-ci bot commented Nov 26, 2024

Hi @tedhtchang. Thanks for your PR.

I'm waiting for a trustyai-explainability member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@ruivieira ruivieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openshift-ci openshift-ci bot added the lgtm label Dec 2, 2024
@ruivieira ruivieira added kind/enhancement New feature or request kind/bug Something isn't working and removed kind/enhancement New feature or request labels Dec 2, 2024
@ruivieira ruivieira changed the title Disallow empty nodeAffinity fix(lmeval): Disallow empty nodeAffinity Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:ec5acb605119673963a27ddbd8e9ab1523995a2c

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:ec5acb605119673963a27ddbd8e9ab1523995a2c

📦 LMES job image: quay.io/trustyai/ta-lmes-job:ec5acb605119673963a27ddbd8e9ab1523995a2c

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-ec5acb605119673963a27ddbd8e9ab1523995a2c

Copy link

openshift-ci bot commented Dec 2, 2024

@tedhtchang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e ec5acb6 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Collaborator

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruivieira, yhwang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 8f30281 into trustyai-explainability:main Dec 4, 2024
8 of 11 checks passed
ruivieira pushed a commit that referenced this pull request Dec 11, 2024
Signed-off-by: ted chang <[email protected]>
(cherry picked from commit 8f30281)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Empty nodeSelectorTerm in Pod
3 participants