Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Option to increase output size. #54

Open
tabarra opened this issue Aug 28, 2022 · 2 comments
Open

[Request] Option to increase output size. #54

tabarra opened this issue Aug 28, 2022 · 2 comments

Comments

@tabarra
Copy link

tabarra commented Aug 28, 2022

Duplicating vowels is good, but some locales are REALLY verbose, I would like an option to 3x or maybe even 4x any vowels.

@tabarra
Copy link
Author

tabarra commented Aug 29, 2022

If you want, I can PR it, sounds easy enough to just replace the line below with opts.map[char].repeat(elongateLength) or something.

pseudoLocalizedText += opts.map[char] + opts.map[char];

Just let me know how you want this to be reflected in the package options.

@tryggvigy
Copy link
Owner

tryggvigy commented Sep 12, 2022

Hey @tabarra! Sorry for the slow reply. I think this is reasonable to add :) Perhaps repeatCommonVowelsTimes is more descriptive? I think this option could replace the elongate boolean option. repeatCommonVowelsTimes: 0 would result in the same behavior as elongate: false

We can default repeatCommonVowelsTimes = 1 Probably would be good to add a jsdoc comment explaining what this option does so folks can see that through the language server, for example when hovering over the option in VSCode. Something like

/**
 * The number of times "a", "e" "o", and "u" should be repeated.
 * Default to `1` which results in ~30% longer English text.
 */
repeatCommonVowelsTimes = 1

Feel free to make a PR if you want! Otherwise, I'll get around to making this improvement eventually. I can't promise it will be soon though since I don't have a lot of time for open-source these days :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants