Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed excellon-drill snapshot test #19

Merged
merged 1 commit into from
Oct 8, 2024
Merged

fixed excellon-drill snapshot test #19

merged 1 commit into from
Oct 8, 2024

Conversation

ShiboSoftwareDev
Copy link
Contributor

file now diffs and doesn't concatenate like it used to

seveibar
seveibar approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's weird that the string was the issue- is there an underlying issue in bun-match-svg?

@ShiboSoftwareDev
Copy link
Contributor Author

@seveibar these are the props and you passed a string as the first argument
image
not sure what you intended

@seveibar
Copy link
Contributor

seveibar commented Oct 8, 2024

oh it's toMatchSnapshot not toMatchSvgSnapshot

@seveibar seveibar merged commit 14f7e6e into tscircuit:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShiboSoftwareDev @seveibar