Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jscad-fiber is breaking the view in 3d-viewer #93

Closed
wants to merge 2 commits into from
Closed

fix: jscad-fiber is breaking the view in 3d-viewer #93

wants to merge 2 commits into from

Conversation

Anshgrover23
Copy link

Fixes #92
/claim #92

@algora-pbc algora-pbc bot mentioned this pull request Nov 16, 2024
Open
@Anshgrover23
Copy link
Author

@seveibar @imrishabh18 kindly review this PR also sir.

@imrishabh18
Copy link
Member

What is the reason of introducing a new package lodash? Can you investigate more about what the issue really is and can we figure out a solution without using lodash

@Anshgrover23
Copy link
Author

@imrishabh18 we have used it to create a deep clone to ensure the jscad instance remains isolated from operations within the renderer, which could otherwise lead to bugs in the 3D rendering view.

@Anshgrover23
Copy link
Author

@imrishabh18 yes we can implement it without lodash as well

seveibar
seveibar requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not like lodash, im also highly skeptical of this implementation- why clone jscad? Plus you added a bunch of logging

@seveibar seveibar closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seveibar seveibar seveibar requested changes

Assignees
No one assigned
Labels
🙋 Bounty claim
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Latest version of jscad-fiber is breaking the view in 3d-viewer
3 participants
@Anshgrover23 @imrishabh18 @seveibar