Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace Hint / Trace Render Modifications #38

Open
2 of 5 tasks
seveibar opened this issue Aug 21, 2024 · 4 comments
Open
2 of 5 tasks

Trace Hint / Trace Render Modifications #38

seveibar opened this issue Aug 21, 2024 · 4 comments
Assignees

Comments

@seveibar
Copy link
Contributor

seveibar commented Aug 21, 2024

  • * The tracehint should NOT draw the trace- the trace should draw the trace #41
  • * The tracehint should show the width that the trace will get at each offset and the user should be able to "click and drag" to make the trace thicker in the pcb viewer
  • * The tracehint should have mixed-blend-mode: difference, same as the dimension overlay as shown in the code screenshot below
  • * There should be two circles on a trace hint when the trace_width is defined. One circle corresponds to the trace_width at that offset. If the trace_width isn't defined- the user hasn't specified their desired width at that point
  • * This is not needed for the initial PR, but there should be a square that the user can click and drag to adjust the trace_width, when they click and drag the square, it emits an "EditEvent"

image

image

we're getting closer- I didn't have a design totally in mind when we started so I can do a bit better next time, the only thing I knew is that we wanted to support interpolated traces, but I didn't realize we were editing the trace hint this time because of the same color etc.

Originally posted by @seveibar in #37 (comment)

CC @imrishabh18

Copy link

homie-gg bot commented Aug 21, 2024

Here are some pull requests that might be helpful reference for this task:

@imrishabh18
Copy link
Member

imrishabh18 commented Aug 26, 2024

@seveibar Currently, this is how the soup looks like when you build your circuit and add a trace_hint with the offsets. And this is visible when you click on the Edit trace button. Going forward we will be adding the offset route props for the trace and not trace_hint with the route thickness mode and it will be only visible when you click Edit trace button like now. Is this correct?

Or the trace will always be visible in that polygon shape and only the trace_hint will be visible on clicking the Edit trace button

Screenshot 2024-08-27 at 1 55 57 AM
Screenshot 2024-08-27 at 1 56 15 AM

@imrishabh18 imrishabh18 self-assigned this Aug 26, 2024
@seveibar
Copy link
Contributor Author

Or the trace will always be visible in that polygon shape

Yes the trace should always be visible in the polygon shape

Going forward we will be adding the offset route props for the trace

We won't add offset for a trace. A trace hint is used to generate a trace inside of tscircuit/builder and should keep the offset prop

route thickness mode

Trace's should have a route thickness mode, not a trace hint. It's not totally clear how the props for this will look but probably like this:

<trace thicknessMode="interpolated" from=".R1 > .left" to=".R2 > .right" />

Copy link

homie-gg bot commented Aug 27, 2024

This might be a duplicate of: Trace Hints should allow specifying a trace width.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants