Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The chip 3D view is missing the chip (regression) #222

Closed
imrishabh18 opened this issue Nov 15, 2024 · 10 comments
Closed

The chip 3D view is missing the chip (regression) #222

imrishabh18 opened this issue Nov 15, 2024 · 10 comments

Comments

@imrishabh18
Copy link
Member

https://tscircuit.com/imrishabh18/motor-driver-breakout

The 3D view is missing the chip, while it was present before.

Image

@seveibar
Copy link
Contributor

seveibar commented Nov 15, 2024

@imrishabh18 is it a jlcpcb chip? This is likely because of a CORS error when we use both snippets.tscircuit.com and tscircuit.com. To fix it, we have to add a url parameter that includes the domain to "bash the cache"

@seveibar
Copy link
Contributor

In effect, this means the fix has to be in core. Basically in 3d viewer or jscad-electronics we need to append the domain as a query parameter whenever we request a model from the model cdn. It doesn't matter if the model cdn accepts the parameter or not- it's just to trick the browser into bashing the cache.

e.g. modelcdn.tscircuit.com?.....&origin=snippet.tscircuit.com

@seveibar
Copy link
Contributor

/bounty $15

Copy link

algora-pbc bot commented Nov 15, 2024

💎 $15 bounty • tscircuit

Steps to solve:

  1. Start working: Comment /attempt #222 with your implementation plan
  2. Submit work: Create a pull request including /claim #222 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to tscircuit/snippets!

Add a bountyShare on socials

@imrishabh18
Copy link
Member Author

@seveibar The error is not consistent, when I open the chip 3d view here - https://tscircuit.com/imrishabh18/TB6612FNG. I can see the chip rendering file.
But now the 3d view is failing for the motor-driver - https://tscircuit.com/imrishabh18/motor-driver-breakout

@Anshgrover23
Copy link
Contributor

@imrishabh18 @seveibar there is no missing chip in motr-driver also seeing in the 3d view.
Image

@imrishabh18
Copy link
Member Author

@Anshgrover23 Yeah, the errors in the 3d viewer are not consistent. The jscad-fiber version when updated in 3d-viewer was breaking the view. Cause the createJSCADRenderer in fiber is modifying the structure of jscadPlan.

I will create an issue in the jscad-fiber about this, if you want to take a look and tackle this. It would be great

@Anshgrover23
Copy link
Contributor

@imrishabh18 yes i would love to work on that.

@imrishabh18
Copy link
Member Author

tscircuit/jscad-fiber#92

Take a look @Anshgrover23. I have added some of my findings while debugging

@Anshgrover23
Copy link
Contributor

@imrishabh18 i am looking into it. kindly help me more if u can review my PR this issue also .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants