-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simpler lineage struct #2296
Simpler lineage struct #2296
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
==========================================
- Coverage 91.09% 90.96% -0.14%
==========================================
Files 20 20
Lines 11921 12003 +82
Branches 2435 2444 +9
==========================================
+ Hits 10860 10919 +59
- Misses 581 598 +17
- Partials 480 486 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Cover all the easy cases Get SMCK working Add a "lineage" attr to Segment and fixup sweeps code Basic DTWF seems to work Fixup algorithms minimally
Make some progress. Disable DTWF tests for now Minimal changes to get smck working Fix DTWF simulations Fixup incorrectly failing test Make results reproducible by seed Revert back to old seed for failing test Skip segfaulting pedigree and sweep tests Fix sweeps Fix pedigree sims Keep track of lineages
Newer versions of jsonschema emit a DeprecationWarning
a74a21c
to
8ee8cb1
Compare
I think this is the basic changes needed to start with. Would you mind having a quick look over to see if I've made any obvious mistakes (like keeping an msp_verify() left over from debugging etc) please @GertjanBisschop? |
I'm going to go ahead and merge this, there's no point in keeping a big diff like this lying around. Sorry to anyone who's code is clobbered! |
Work towards #2294
Work on adding a lineage struct that we store in the algorithm state in preference to using just segments. This does the initial bit where we just define this structure minimally in C and Python. Actually using it to some advantage can be done in follow-ups.