Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade VariantSync to newest Eclipse and FeatureIDE version #45

Open
pmbittner opened this issue Oct 15, 2020 · 1 comment · Fixed by #53
Open

Upgrade VariantSync to newest Eclipse and FeatureIDE version #45

pmbittner opened this issue Oct 15, 2020 · 1 comment · Fixed by #53
Assignees
Milestone

Comments

@pmbittner
Copy link
Collaborator

pmbittner commented Oct 15, 2020

Currently, VariantSync only runs with very old versions of Eclipse and FeatureIDE due to numerous changes in the FeatureIDE library.
VariantSync should be upgraded to run with the newest Version v3.7.0 (https://featureide.github.io/) of FeatureIDE.

@pmbittner pmbittner added this to the Backlog milestone Oct 15, 2020
@wurstbroteater
Copy link
Collaborator

wurstbroteater commented Nov 24, 2020

Problem occurrence & description

  1. de.tubs.variatnsync.core :

    • Several methods of ComposerExtensionClass have changed.
  2. de.tubs.variantsync.core.managers :

    • Type Mismatch - expected IFile but got Path.
  3. de.tubs.variantsync.core.managers.data

    • Type Mismatch - expected IFile but got Path.
  4. de.tubs.variantsync.core.managers.persistence

    • Method headers of overloaded methods have changed.
  5. de.tubs.variantsync.core.patch

    • CoreExtensionLoader has been removed.
  6. de.tubs.variantsync.core.patch.base

    • Methods of IDeltaFactory<Chunk> have changed.
  7. Context.setPossibeWords(?????))

Summary

  • Most of these problems occur because the usage of the IFile interface is deprecated and should be replaced with Path.

(* Differences between IPersistentFormat and APersistentFormat, CoreExtensionLoader, IExtensionLoader and EclipseExtensionLoader ?)

Solutions & Decisions

  • Addressing 1-3 :
    (- ComposerExtensionCLass ua forPreprocessor Integration)

  • Compare : 4-6 setExtensionLoader and setExtensionLoaderInternal. What does CoreExtensionLoader (DefaultDeltaFactory.java) and refactoring old methods. (@jeremiaheinle)

  • Addressing 7:

    • The method has been deleted in FeatureIDE since this commit
      FeatureIDE/FeatureIDE@b679c39#diff-02b7a28d524fe3c717b03a9621030e760993f27c394403d3d837e36e4c4489fa
      Since there is no provision of a new method, it can be deleted. (@wurstbroteater)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment