Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Style: Magic Numbers and Strings #56

Open
wurstbroteater opened this issue Jan 28, 2021 · 0 comments · Fixed by #63
Open

Code Style: Magic Numbers and Strings #56

wurstbroteater opened this issue Jan 28, 2021 · 0 comments · Fixed by #63
Assignees
Labels
enhancement minor Minor fixes and improvement with low priority

Comments

@wurstbroteater
Copy link
Collaborator

wurstbroteater commented Jan 28, 2021

In the project, there are several occurences of so called magic numbers like here: #53 (comment)

Also there are occurences of unclear REGEX usages like here: #53 (comment) and #53 (comment)

It is not OS save to use \n, so we have to change it to String.format("%n") and StringBuilder should be used in general

This issue is considered as done if:

  • All unclear magic numbers are identified and documented (optional: in wiki)
  • The purpose or usage of the magic number has been documented (optional : in wiki)
  • The purpose or usage of the REGEX Strings has been documented (optional : in wiki)
  • All occurences of \n have been changed to String.format("%n")
  • Every usage of String is be replaced with StringBuilder ( this also includes String concatenation with +)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement minor Minor fixes and improvement with low priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants