-
-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use modified bootstrap $primary variable #46
Comments
@imtiazShakil Sorry for my late response. Why don't you just add |
for my project, I required to change the bootstrap default but the issue is, |
Thank you for this theme. I have exactly the same problem, I think that you should use colors from bootstrap variables, otherwise when using sass this select ignores theme colors customizations. |
Using the bootstrap function to get the theme colour means that the source can be used by people who have overridden the primary theme colour by setting it in $theme-colours as per bootstrap docs https://getbootstrap.com/docs/4.5/getting-started/theming/#modify-map Fixes ttskch#46
Probably related to #51 |
We have a number of variables (input padding for example) that the layout import of re-importing bootstrap is clobbering. I don't think there's a way that you can re-import the variables without breaking a lot of stuff. I think the installation instructions will require that bootstrap already be imported before importing the library, which I think is a reasonable ask. For now, we've just copied the scss into our own source, but that's not ideal. |
I attach you here my solution, hope it will help to solve this. |
I think that this issue has been fixed via e946eed, because Bootstrap variables are only used to build the default distributable |
thanks. I'm closing the issue |
In my
styles.scss
,I import
_variables.scss
to modify boostrap default$blue
variable which changes bootstrap's$primary
colour.but this change is not picked up by your
layout.scss
because you are importing bootstrap variables again.Because of this mouse hovered item doesn't display the right colour:
The text was updated successfully, but these errors were encountered: