fix: replace TargetMetadata.isLocal with Target.type enum
#91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepicrft
changed the title
TargetMetadata.isLocal with Target.type enum
pepicrft
force-pushed
the
12-26-turn_islocal_into_target.type
branch
from
4be3c2d to
1efa61c
Compare
pepicrft
force-pushed
the
12-26-turn_islocal_into_target.type
branch
from
1efa61c to
850d308
Compare
fortmarek
approved these changes
Dec 26, 2024
| } | ||
|
|
||
| init(tags: Set<String>, isLocal: Bool) { | ||
| init(tags: Set<String>, isLocal _: Bool) { |
There was a problem hiding this comment.
Suggested change
| init(tags: Set<String>, isLocal _: Bool) { | |
| init(tags: Set<String>) { |
| @@ -0,0 +1,6 @@ | |||
| public enum TargetType: Codable, Hashable, Equatable, Sendable { | |||
| /// A target is local when it hasn't been resolved and pulled by a package manager (e.g., SPM). | |||
There was a problem hiding this comment.
Suggested change
| /// A target is local when it hasn't been resolved and pulled by a package manager (e.g., SPM). | |
| /// A target is local when it hasn't been resolved and pulled by a package manager (e.g., SwiftPM). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
isLocalboolean property with a newTargetTypeenum that better represents whether a target is local or remote. This change provides more explicit semantics around target types and removes the need for documentation comments explaining the boolean's meaning.