Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #shebang header to docker-helloworld.sh #196

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add #shebang header to docker-helloworld.sh #196

merged 1 commit into from
Aug 23, 2023

Conversation

BreakingPitt
Copy link

@BreakingPitt BreakingPitt commented Aug 23, 2023 •
edited
Loading

Closes: #170

What is the purpose of the change

Add #shebang header to docker-helloworld.sh

@BreakingPitt BreakingPitt requested a review from tungbq as a code owner August 23, 2023 09:51
tungbq
tungbq approved these changes Aug 23, 2023
View reviewed changes
Copy link
Owner

@tungbq tungbq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @BreakingPitt for your contribution!

@tungbq tungbq merged commit a37ee81 into tungbq:main Aug 23, 2023
@tungbq
Copy link
Owner

tungbq commented Aug 23, 2023

Thanks @BreakingPitt again for your awe some contribution on this repo!
If you find this repository helpful, kindly consider showing your appreciation by giving it a star ⭐ Thanks! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tungbq tungbq tungbq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker: add #!/bin/bash shebang header to docker-helloworld.sh
2 participants
@BreakingPitt @tungbq