Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style change: better syntax for left/right #18

Open
mappum opened this issue Aug 27, 2019 · 0 comments
Open

Style change: better syntax for left/right #18

mappum opened this issue Aug 27, 2019 · 0 comments

Comments

@mappum
Copy link
Collaborator

mappum commented Aug 27, 2019

Throughout the codebase, we use left: bool to parameterize between left and right. This is not very intuitive to read (e.g. tree.attach(true, child)).

Could fix by adding an enum Side { Left, Right }, and/or adding variants of the methods with _left and _right suffixes.

This is only a style change and probably doesn't affect the compiler's output at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant