We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throughout the codebase, we use left: bool to parameterize between left and right. This is not very intuitive to read (e.g. tree.attach(true, child)).
left: bool
tree.attach(true, child)
Could fix by adding an enum Side { Left, Right }, and/or adding variants of the methods with _left and _right suffixes.
enum Side { Left, Right }
_left
_right
This is only a style change and probably doesn't affect the compiler's output at all.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Throughout the codebase, we use
left: bool
to parameterize between left and right. This is not very intuitive to read (e.g.tree.attach(true, child)
).Could fix by adding an
enum Side { Left, Right }
, and/or adding variants of the methods with_left
and_right
suffixes.This is only a style change and probably doesn't affect the compiler's output at all.
The text was updated successfully, but these errors were encountered: