Feat/deactivate #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…toller and validations and shoulda matchers
Finished Setting up my coupons model and generating my schema and con…
Added test for happy/sad path for coupon show and added show action
Added test for happy/sad path coupon index, and action for coupon controller
Refactor/coupon model spec
Added create route and post test for happy path, and create action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the CouponsController to handle CRUD operations for coupons within the merchant context. It includes:
Controller Actions: index, show, create, and update methods for managing coupons.
Coupon Model: Validations for uniqueness, presence, and active status.
Serializer: A CouponSerializer to format JSON responses consistently.
Migrations: Creation of the coupons table and addition of a coupon reference in the invoices table.
Factory and Specs: Added FactoryBot setup for coupons and comprehensive RSpec tests for controller actions and model validations.
This ensures a robust and scalable solution for managing merchant coupons in the application.