Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dustin Peukert #10

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Dustin Peukert #10

wants to merge 29 commits into from

Conversation

DustinPeukert
Copy link

Was able to get through Iterations 1-3 fully?(without missing anything this time I believe?)

Was able to get through iteration 4 partially

  • finished the date method functionality

I did create my own helper method bidder_objects for use with the bidder_info method
I did make sure write a test for it too!

@DustinPeukert
fix errors
4d06b72
@DustinPeukert
fix errors
1e67b43
@DustinPeukert
fix error; add #item_names
5e98bd1
@DustinPeukert
Merge pull request #1 from DustinPeukert/iteration_1
2d616d6 
Iteration 1
@DustinPeukert
add assertions for new attribute
a7de91a
@DustinPeukert
add new attribute #bids
77c8ba6
@DustinPeukert
add test for #add_bid
a1cf04c
@DustinPeukert
write #add_bid
77b9242
@DustinPeukert
writes test for #current_high_bid
e2ef799
@DustinPeukert
write #current_high_bid method
90f6909
@DustinPeukert
add setup and write test for #unpopular_items
a9514db
@DustinPeukert
write #unpopular_items method
8bdcb81
@DustinPeukert
write test for #potential_revenue method
268a0c5
@DustinPeukert
write #potential_revenue method
2a5d1e1
@DustinPeukert
Merge pull request #2 from DustinPeukert/iteration_2
5a6a78b 
Iteration 2
@DustinPeukert
write test for #bidders method
e6e85c6
@DustinPeukert
write #bidders method
5dcd133
@DustinPeukert
add test for #close_bidding
4731dc2
@DustinPeukert
write #close_bidding method; add logic to #add_bid
e2eb80d
@DustinPeukert
write test for helper method #bidder_objects
cac140c
@DustinPeukert
write #bidder_objects helper method
59fb296
@DustinPeukert
write test for #bidder_info
77bf0bf
@DustinPeukert
fix syntax error; swap useless logic to make test more robust
8bd8170
@DustinPeukert
write #bidder_info method
9091b2b
@DustinPeukert
Merge pull request #3 from DustinPeukert/iteration_3
36b6544 
Iteration 3
@DustinPeukert
write stub for Date.today and add assertion for date attribute
01223af
@DustinPeukert
fix typo
6b3613f
@DustinPeukert
add date attribute and write #date method
3a5103e
@DustinPeukert
Merge pull request #4 from DustinPeukert/iteration_4
0ff8777 
Iteration 4 - Partial
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DustinPeukert