Feat/job application show

README.md

@@ -48,31 +48,31 @@ Successful Response:
 ```
 Status: 201 Created
 Body: {
-    "data": {
-        "id": "4",
-        "type": "user",
-        "attributes": {
-            "name": "John Doe",
-            "email": "[email protected]"
-        }
+  "data": {
+    "id": "4",
+    "type": "user",
+    "attributes": {
+      "name": "John Doe",
+      "email": "[email protected]"
     }
+  }
 }
 ```
 
 Error Responses:
 ```
 Status: 400 Bad Request
 Body: {
-    "message": "Email has already been taken",
-    "status": 400
+  "message": "Email has already been taken",
+  "status": 400
 }
 ```
 
 ```
 Status: 400 Bad Request
 Body: {
-    "message": "Password confirmation doesn't match Password",
-    "status": 400
+  "message": "Password confirmation doesn't match Password",
+  "status": 400
 }
 ```
 
@@ -86,25 +86,25 @@ Successful Response:
 ```
 Status: 200 OK
 Body: {
-    "data": [
-        {
-            "id": "1",
-            "type": "user",
-            "attributes": {
-                "name": "Danny DeVito",
-                "email": "danny_de_v"
-            }
-        },
-        ...
-        {
-            "id": "4",
-            "type": "user",
-            "attributes": {
-                "name": "John Doe",
-                "email": "[email protected]"
-            }
-        }
-    ]
+  "data": [
+    {
+      "id": "1",
+      "type": "user",
+      "attributes": {
+        "name": "Danny DeVito",
+        "email": "danny_de_v"
+      }
+    },
+    ...
+    {
+      "id": "4",
+      "type": "user",
+      "attributes": {
+        "name": "John Doe",
+        "email": "[email protected]"
+      }
+    }
+  ]
 }
 ```
 
@@ -118,14 +118,14 @@ Successful Response:
 ```
 Status: 200 OK
 Body: {
-    "data": {
-        "id": "3",
-        "type": "user",
-        "attributes": {
-            "name": "Lionel Messi",
-            "email": "futbol_geek"
-        }
+  "data": {
+    "id": "3",
+    "type": "user",
+    "attributes": {
+      "name": "Lionel Messi",
+      "email": "futbol_geek"
     }
+  }
 }
 ```
 
@@ -147,30 +147,30 @@ Successful Response:
 ```
 Status: 200 OK
 Body: {
-    "data": {
-        "id": "4",
-        "type": "user",
-        "attributes": {
-            "name": "Nathan Fillon",
-            "email": "firefly_captian"
-        }
+  "data": {
+    "id": "4",
+    "type": "user",
+    "attributes": {
+      "name": "Nathan Fillon",
+      "email": "firefly_captian"
     }
+  }
 }
 ```
 Error Responses:
 ```
 Status: 400 Bad Request
 Body: {
-    "message": "Email has already been taken",
-    "status": 400
+  "message": "Email has already been taken",
+  "status": 400
 }
 ```
 
 ```
 Status: 400 Bad Request
 Body: {
-    "message": "Password confirmation doesn't match Password",
-    "status": 400
+  "message": "Password confirmation doesn't match Password",
+  "status": 400
 }
 ```
 
@@ -313,21 +313,55 @@ Status: 200
    :type=>"job_application",
    :attributes=>
     {:position_title=>"Jr. CTO",
-     :date_applied=>"2024-10-31",
-     :status=>1,
-     :notes=>"Fingers crossed!",
-     :job_description=>"Looking for Turing grad/jr dev to be CTO",
-     :application_url=>"www.example.com",
-     :contact_information=>"[email protected]",
-     :company_id=>35}}
-     }
+      :date_applied=>"2024-10-31",
+      :status=>1,
+      :notes=>"Fingers crossed!",
+      :job_description=>"Looking for Turing grad/jr dev to be CTO",
+      :application_url=>"www.example.com",
+      :contact_information=>"[email protected]",
+      :company_id=>35}}
+}
 ```
 
 Unsuccessful Response:
 ```
 {:message=>"Company must exist and Position title can't be blank", :status=>400}
 ```
 
+#### Get a Job Application 
+Request:
+```
+GET /api/v1/users/:user_id/job_applications/:job_application_id
+```
+
+Successful Response:
+```
+Status: 200 OK
+{:data=>
+  {:id=>"4",
+   :type=>"job_application",
+   :attributes=>
+    {:position_title=>"Jr. CTO",
+      :date_applied=>"2024-10-31",
+      :status=>1,
+      :notes=>"Fingers crossed!",
+      :job_description=>"Looking for Turing grad/jr dev to be CTO",
+      :application_url=>"www.example.com",
+      :contact_information=>"[email protected]",
+      :company_id=>35}}
+}
+```
+
+Unsuccessful Response(job application does not exist OR belongs to another user):
+```
+{:message=>"Job application not found", :status=>404}
+```
+
+Unsuccessful Response(missing job application ID param):
+```
+{:message=>"Job application ID is missing", :status=>400}
+```
+
 If the user is not authenticated:
 ```
 {

app/controllers/api/v1/job_applications_controller.rb

@@ -13,6 +13,25 @@ def create
     end
   end
 
+  def show
+
+    if params[:id].blank?
+      render json: ErrorSerializer.format_error(ErrorMessage.new("Job application ID is missing", 400)), status: :bad_request
+      return
+    end
+
+    user = User.find(params[:user_id])
+    authorize user
+
+    job_application = JobApplication.find_by(id: params[:id])
+
+    if job_application.nil? || job_application.user_id != user.id
+      render json: ErrorSerializer.format_error(ErrorMessage.new("Job application not found", 404)), status: :not_found
+    else
+      render json: JobApplicationSerializer.new(job_application), status: :ok
+    end
+  end
+
 
   def index
     job_applications = @current_user.job_applications 

app/policies/job_policy.rb

@@ -5,10 +5,18 @@ class JobPolicy < ApplicationPolicy
   # code, beware of possible changes to the ancestors:
   # https://gist.github.com/Burgestrand/4b4bc22f31c8a95c425fc0e30d7ef1f5
 
+  def index?
+    admin? || user == record
+  end
+
+  def show?
+    admin? || user == record
+  end
+
   class Scope < ApplicationPolicy::Scope
     # NOTE: Be explicit about which records you allow access to!
-    # def resolve
-    #   scope.all
-    # end
+    def resolve
+      scope.all
+    end
   end
 end

config/routes.rb

@@ -11,7 +11,7 @@
     namespace :v1 do
       resources :users, only: [:create, :index, :show, :update] do
 
-        resources :job_applications, only: [:create, :index]
+        resources :job_applications, only: [:create, :index, :show]
         resources :companies, only: [:create, :index]
         resources :contacts, only: [:create, :index]