refactor: refactors company controller policies and tests to include … #45
+107
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…authorization Co-authored-by: Jim Macur <[email protected]>
| def index? | ||
| user.present? | ||
| end | ||
|
|
There was a problem hiding this comment.
So you only want to check if a user is present and, if true, allow this action? Check out the admin? and user? methods inherited from application_policy.rb.
Correct me if I'm wrong, but it looks like it is checking the presence of a user and not checking the role of a user.
Furthermore, should an admin also be authorized to take these controller actions? As of now, a user can ONLY be either a :user (by default) or an :admin (by using the set_role(role_name)) method in user.rb)
There was a problem hiding this comment.
Yes - good catch. We have updated the index? to utilize the ApplicationPolicy and allow admin access to the index (not create)
We pushed the change.
…o access index Co-authored-by: Melchor De La Rosa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…authorization
Type of Change
Description
Refactored our Companies controller to include the Pundit and rollify functionality, Also refactored the company__policy spec to test the authorization our users had for the companies. We added the rollify method in our company model to use the roles.
Motivation and Context
This change was required because, we introduced authorization to our app and our companies controller wasn't set up for that.
Added Test?
Checklist: