Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appliances which require a domain to be set, should auto redirect IP access to the domain #958

Closed
14 of 17 tasks
JedMeister opened this issue Nov 2, 2017 · 5 comments
Closed
14 of 17 tasks

Comments

@JedMeister
Copy link
Member

JedMeister commented Nov 2, 2017

This issue is to consolidate issues #869 & #871 as well as highlight the other appliances which need to be checked. Here are all the appliances which require a domain to be set (as of v14.2):

Without digging into the code, I can't be 100% clear that they will necessarily all need to be updated, but they will need to be tested. If the main site doesn't work as it should when contacting via IP (e.g. http://xxx.xxx.xxx.xxx) address, we should be redirecting to the domain.

FWIW, the below appliances have Apache redirect configured, so may provide some useful hints?! They all redirect to HTTPS, but that shouldn't be required (but is probably desirable):

@l-arnold
Copy link

l-arnold commented Nov 2, 2017 via email

@JedMeister
Copy link
Member Author

JedMeister commented May 30, 2018

@spaghettimaster - I was about to remove you from this issue, as the 3 remaining apps are canvas, gitlab (both @qq7) and pwik (@OnGle). However, perhaps they would like your assistance with them?

I'm almost certain that @OnGle would be happy for you to take care of piwik (soon to be renamed matomo - see #1003) but we're still blocked by the fact that there isn't a matomo Debian package. However, as I just noted, we could move to a "zipball" install. Hopefully the existing curl code would still be applicable (I haven't tested?!).

@JedMeister
Copy link
Member Author

Added oscommerce.

@JedMeister
Copy link
Member Author

Added mediawiki to the list and ticked it off straight away - resolved via turnkeylinux-apps/mediawiki#13

@OnGle OnGle modified the milestones: 15.0, 15.1 Oct 30, 2018
@JedMeister JedMeister removed this from the 15.1 milestone Mar 28, 2020
@JedMeister JedMeister added this to the 16.0 milestone Mar 28, 2020
@JedMeister
Copy link
Member Author

This should be pretty much done now so closing. If any are actually outstanding, or there are new ones, best to open a specific new issue for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment