-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Appliances which require a domain to be set, should auto redirect IP access to the domain #958
Comments
Easy to have Magento and Joomla redirect to Https. I believe the Odoo Appliance was redirecting to Https out of the box.
…________________________________
From: Jeremy Davis <[email protected]>
Sent: Nov 1, 2017 10:47 PM
To: turnkeylinux/tracker
Cc: Subscribed
Subject: [turnkeylinux/tracker] Appliances which require a domain to be set, should auto redirect IP access to the domain (#958)
This issue is to consolidate issues #869 & #871 as well as highlight the other appliances which need to be checked. Here are all the appliances which require a domain to be set (as of v14.2):
canvas
django - #869 (not tagged in this issue)
drupal8
elgg (should be ok - see below)
ghost
gitlab
gnusocial
icescrum
magento
phplist
piwik
prestashop
punbb
simplemachines
zencart - #871 (not tagged in this issue)
Without digging into the code, I can't be 100% clear that they will necessarily all need to be updated, but they will need to be tested. If the main site doesn't work as it should when contacting via IP (e.g. http://xxx.xxx.xxx.xxx) address, we should be redirecting to the domain.
FWIW, the below appliances have Apache redirect configured, so may provide some useful hints?! They all redirect to HTTPS, but that shouldn't be required (but is probably desirable):
owncloud: redirects to https - https://github.com/turnkeylinux-apps/owncloud/tree/master/overlay/etc/apache2/sites-available/owncloud.conf#L8-L9
mahara: redirects to https - https://github.com/turnkeylinux-apps/mahara/blob/master/overlay/etc/apache2/sites-available/mahara.conf#L6-L8
nextcloud: redirects to https (same as ownCloud) - https://github.com/turnkeylinux-apps/nextcloud/blob/master/overlay/etc/apache2/sites-available/nextcloud.conf#L8-L9
elgg: redirects to https - https://github.com/turnkeylinux-apps/elgg/blob/master/overlay/etc/apache2/sites-available/elgg.conf#L5-L7
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/turnkeylinux/tracker","title":"turnkeylinux/tracker","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/turnkeylinux/tracker"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Appliances which require a domain to be set, should auto redirect IP access to the domain (#958)"}],"action":{"name":"View Issue","url":"#958"}}}
|
@spaghettimaster - I was about to remove you from this issue, as the 3 remaining apps are canvas, gitlab (both @qq7) and pwik (@OnGle). However, perhaps they would like your assistance with them? I'm almost certain that @OnGle would be happy for you to take care of piwik (soon to be renamed matomo - see #1003) but we're still blocked by the fact that there isn't a matomo Debian package. However, as I just noted, we could move to a "zipball" install. Hopefully the existing curl code would still be applicable (I haven't tested?!). |
Added oscommerce. |
Added mediawiki to the list and ticked it off straight away - resolved via turnkeylinux-apps/mediawiki#13 |
This should be pretty much done now so closing. If any are actually outstanding, or there are new ones, best to open a specific new issue for them. |
This issue is to consolidate issues #869 & #871 as well as highlight the other appliances which need to be checked. Here are all the appliances which require a domain to be set (as of v14.2):
Without digging into the code, I can't be 100% clear that they will necessarily all need to be updated, but they will need to be tested. If the main site doesn't work as it should when contacting via IP (e.g. http://xxx.xxx.xxx.xxx) address, we should be redirecting to the domain.
FWIW, the below appliances have Apache redirect configured, so may provide some useful hints?! They all redirect to HTTPS, but that shouldn't be required (but is probably desirable):
The text was updated successfully, but these errors were encountered: