Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy limbo java library to maven central #943

Open
Tracked by #615
seonWKim opened this issue Feb 9, 2025 · 3 comments
Open
Tracked by #615

Deploy limbo java library to maven central #943

seonWKim opened this issue Feb 9, 2025 · 3 comments
Milestone

Comments

@seonWKim
Copy link
Contributor

seonWKim commented Feb 9, 2025

While bindings/java is a WIP state, deploying the bindings/java to maven central will let potential users(and attract contributors) to easily use it by simply adding dependencies to their pom.xml or build.gradle.

For example

<dependency>
    <groupId>org.github.tursodatabase</groupId>
    <artifactId>limbo</artifactId>
    <version>0.0.1-SNAPSHOT</version>
</dependency>
dependencies {
  implementation("org.github.tursodatabase:limbo:0.0.1-SNAPSHOT") 
}

However, as I'm not the maintainer of limbo, I need some help from @penberg , @glommer

How to upload limbo to maven central

  1. Register namespace in [Central Portal Website]
  • namespace example io.github.tursodatabase
    • then, we can register our (limbo) library as io.github.tursodatabase:limbo:1.0.0-SNAPSHOT
  • it's recommended to use GitHub as a login provider, so that io.github.tursodatabase namespace can be automatically assigned
    • or, if you prefer other namespaces such as turso.tech or com.tursodatabase, then you need verification code. Add it as a TXT record to your domain's DNS settings and let Sonatype verify it
  • Btw, after deciding which namespace to use, we need to update the package name of java project in bindings/java(which is currently org.github.tursodatabase)
  1. Generate API tokens
  • They are used to authenticate API request to publishing limbo library to maven central. Let's put them as secret variables for the CI
    => we will store these variables as MAVEN_UPLOAD_USERNAME, MAVEN_UPLOAD_PASSWORD
  1. Distribute PGP keys
  • This is used to verify our publication of limbo to Maven Central. We need to save the passphrase and secret key in ASCII-armored format. Let's save them as secret variables for the CI as well.
    => we will store these variables as MAVEN_SIGNING_PASSPHRASE, MAVEN_SIGNING_KEY
  1. Deploy using gradle + Integration with CI

Suggestions

  • Because I'm not eligible to run process 1/2/3, I need help from our great maintainers to set above mentioned variables as secret variables in the CI(so I can use my gradle to publish). Then I'll add a PR in which we can use to integrate CI with publishing libraries to maven central.

References

@seonWKim seonWKim changed the title Deploy bindings/java to maven central Deploy limbo java library to maven central Feb 9, 2025
@penberg
Copy link
Collaborator

penberg commented Feb 10, 2025

@seonWKim I am on this.

@penberg
Copy link
Collaborator

penberg commented Feb 11, 2025

Hey @seonWKim, the namespace is tech.turso (which is something we already had and is verified). Let's fix up the Maven project files, but also rename the package. I have configured both MAVEN_UPLOAD_USERNAME and MAVEN_UPLOAD_PASSWORD secrets, but still looking at how to deal with the PGP key thing, will ping you when that's done.

@seonWKim
Copy link
Contributor Author

Thanks! 🚀 🚀

penberg added a commit that referenced this issue Feb 12, 2025
… Woo

This PR is to prepare for uploading limbo-jdbc to maven
Refer to this [issue](#943)

Closes #990
@penberg penberg added this to the 0.1.0 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants