Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter <meta> tags from notes #404

Open
orthecreedence opened this issue Dec 13, 2021 · 2 comments
Open

Filter <meta> tags from notes #404

orthecreedence opened this issue Dec 13, 2021 · 2 comments
Labels
priority:high This is a high-priority issue project:js This affects the js UI tag:security This is a security issue (encryption problem, data leak, etc) type:bug GET THE RAID
Milestone
v0.7.3

Comments

@orthecreedence
Copy link
Member

Notes allow <meta> tag injection. Ie, a note with the content

<META HTTP-EQUIV="refresh" CONTENT="0; URL=https://google.com">

opens a new browser window to Google. While this problem would happen over person-to-person sharing and thus the severity is limited (because you generally only share with those you trust) it remains high priority.

Special thanks to Rafay Baloch and Muhammad Samak for this report.
@orthecreedence orthecreedence added type:bug GET THE RAID project:js This affects the js UI tag:security This is a security issue (encryption problem, data leak, etc) priority:high This is a high-priority issue labels Dec 13, 2021
@orthecreedence orthecreedence added this to the v0.7.3 milestone Dec 13, 2021
@dbmohit
Copy link

dbmohit commented Jul 26, 2022

can i work on this?

@orthecreedence
Copy link
Member Author

Yeah, please do! This would be a good kick in the pants for me to do a security release. If you need any help getting the app set up, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:high This is a high-priority issue project:js This affects the js UI tag:security This is a security issue (encryption problem, data leak, etc) type:bug GET THE RAID
Projects
None yet
Milestone
v0.7.3
Development

No branches or pull requests
2 participants
@orthecreedence @dbmohit