Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

注文を発行したときにダイアログで注文番号を表示する #70

Merged
merged 3 commits into from
Oct 5, 2024
Merged

注文を発行したときにダイアログで注文番号を表示する #70

merged 3 commits into from
Oct 5, 2024

Conversation

SuzuSys
Copy link
Contributor

@SuzuSys SuzuSys commented Oct 3, 2024 •
edited
Loading

  • セッションごとの注文に特化したデータ構造とその操作を定義した PlacementCompact クラスを追加
  • 注文を発行したあとに注文番号と注文リストを表示する order-published.html を追加
  • 上記の変更に合わせた様々な変更

Resolves #68

exflikt
exflikt reviewed Oct 4, 2024
View reviewed changes
Copy link
Collaborator

@exflikt exflikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PlacementCompact クラスは OrderSession と命名しちゃっていいかもです

exflikt
exflikt reviewed Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@exflikt exflikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいことなんですけど、order_published は order_issued に名前変更しました。
published でも伝わらないことはないと思うんですけど、issued のほうが領収書（レシート）を発行したことが伝わるかなと思います。

exflikt
exflikt approved these changes Oct 5, 2024
View reviewed changes
Copy link
Collaborator

@exflikt exflikt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exflikt exflikt merged commit 11a6ba2 into tut-cc:main Oct 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exflikt exflikt exflikt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

注文を発行したときにダイアログで注文番号を表示する
2 participants
@SuzuSys @exflikt