Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Calendar UI #8640

Open
7 of 18 tasks
murilopereirame opened this issue Mar 4, 2025 · 0 comments · May be fixed by #8644
Open
7 of 18 tasks

Polish Calendar UI #8640

murilopereirame opened this issue Mar 4, 2025 · 0 comments · May be fixed by #8644
Assignees

Comments

@murilopereirame
Copy link
Contributor

murilopereirame commented Mar 4, 2025

Last release contained a few visual bugs and improvements that are not critical but should be fixed.

Bugs

  • Repeat Rule Editor has "Every" hard-coded instead of a translation
  • Event Preview uses the wrong translation for "Third {WEEK_DAY}"
  • Month name still intractable on Three days view expanding/collapsing the day selector in other views

Improvements

  • Week view icon has a different stroke width than other views icons
  • Display a more user-friendly error message for invalid birthdays
  • Handle invalid birthday errors gracefully
  • When focusing the date picker, the mini calendar should only appears if the user clicks on the input or press return
  • When entering the dropdown, the focused item should be the selected one

Tasks:

  • Change "Every" to a translation
  • Fix the translation for Third weekday
  • Change week view icon
  • Make Month Name non-intractable on Three days view
  • Handle invalid birthday errors gracefully
  • Make Date Picker only opens when pressing return
  • Focus the selected item inside dropdown

Test Notes:

  • Every is now a translation
  • Event preview shows the correct translation for third weekday
  • The week view icon has the same line width as the others
  • Clicking or tapping the month name on three days view does nothing
    • Day selector didn't collapse or expand in other views
  • Birthdays Calendar
    • Invalid birthdays doesn't throw an unexpected error while parsing Birthdays Calendar
    • A dialog with a list of contacts with invalid birthdays and a message explaining this is displayed
  • The date picker opens when pressing it
  • The date picker opens when pressing return
  • The selected item is focused inside dropdown when opening it using keyboard
@murilopereirame murilopereirame self-assigned this Mar 4, 2025
@murilopereirame murilopereirame linked a pull request Mar 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant