Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cast core stage data types #201

Merged
merged 8 commits into from
Sep 6, 2023
Merged

Cast core stage data types #201

merged 8 commits into from
Sep 6, 2023

Conversation

thutuva
Copy link
Member

@thutuva thutuva commented Sep 6, 2023

Describe your changes

Please include a summary of any changes.

  • added cross database macro to cast columes as dates
  • casted tables before core union

How has this been tested?

Please describe the tests you ran to verify your changes. Provide instructions or code to reproduce output.

  • dbt run finishes successfully

Reviewer focus

Please summarize the specific items you’d like the reviewer(s) to look into.
n/a

Checklist before requesting a review

  • I have updated the version number in dbt_project.yml file to reflect the release number of this PR
  • I have updated the docs files (by running dbt docs generate/serve and copying the necessary files into the docs folder)
  • I have commented my code as necessary
  • I have added at least one Github label to this PR
  • My code follows style guidelines
  • (Optional) I have recorded a Loom to explain this PR

(Optional) Gif of how this PR makes you feel

Loom link

Copy link
Contributor

@tuvaforrest tuvaforrest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thutuva thutuva merged commit a64d4e7 into main Sep 6, 2023
3 checks passed
@thutuva thutuva deleted the cast-core-stage-data-types branch September 6, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants