Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing custom bucket name, defaulting to tuva name #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chase-jones
Copy link
Contributor

Describe your changes

Creating the bucket name as a dbt variable instead of static. Can be overriden in other's local environments, but will default to be the same for anyone not interested in utilizing different bucket names. Requirement for HA at org.

How has this been tested?

Ran and replicated in local. this worked.

Reviewer focus

One file change

Checklist before requesting a review

  • I have added at least one Github label to this PR (bug, enhancement, breaking change,...)
  • My code follows style guidelines
  • [NA] (New models) YAML files are categorized by sub folder and models listed in alphabetical order
  • [NA] (New models) I have added a config to each new model to enable it for claims and/or clinical data
  • [NA] (New models) I have added the variable tuva_last_run to the final output
  • [:(] (Optional) I have recorded a Loom to explain this PR

Package release checklist

  • [?] I have updated dbt docs
  • [?] I have updated the version number in the dbt_project.yml

(Optional) Gif of how this PR makes you feel

Me vs. Jinja:

@chase-jones
Copy link
Contributor Author

#647

@aneiderhiser aneiderhiser added the community Label for issues created by community members label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Label for issues created by community members
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

2 participants