SOF-2013 - Add Property for Show Style Variant Change on Segments #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew show style variants
RasmusAlbrektsen
requested review from
KvelaGorrrrnio,
MadsThy,
LindvedKrvang and
aardhuis
KvelaGorrrrnio
approved these changes
Jun 13, 2024
src/tv2-common/getSegment.ts
Outdated
| @@ -125,6 +126,10 @@ export async function getSegmentBase<ShowStyleConfig extends TV2ShowStyleConfig> | |||
| segment.isHidden = false | |||
| } | |||
|
|
|||
| segment.definesShowStyleVariant = iNewsStory.cues.some((cue) => | |||
| cue ? cue[0].toLowerCase().includes('showstylevariant') : false | |||
There was a problem hiding this comment.
Depending on the linting setup, you can use optional chaining instead and disregard the false literal:
segment.definesShowStyleVariant = iNewsStory.cues.some(cue => cue?.[0].toLowerCase().includes('showstylevariant'))There was a problem hiding this comment.
Changed to use optional chaining!
src/tv2-common/getSegment.ts
Outdated
| @@ -125,6 +126,10 @@ export async function getSegmentBase<ShowStyleConfig extends TV2ShowStyleConfig> | |||
| segment.isHidden = false | |||
| } | |||
|
|
|||
| segment.definesShowStyleVariant = iNewsStory.cues.some((cue) => | |||
| cue ? cue[0].toLowerCase().includes('showstylevariant') : false | |||
There was a problem hiding this comment.
On the offchance that someone accidentally didn't place the showstyleVariant keyword on line one of the cue, maybe we should check all lines of the cue?
Also, the cue is Sofie=Showstylevariant, not just showstyleVariant. And it would be nice with a constant instead of a magic string :)
There was a problem hiding this comment.
It now checks all cues and uses a constant instead :-)
LindvedKrvang
approved these changes
Jun 14, 2024
RasmusAlbrektsen
deleted the
SOF-2013/addPropertyForShowStyleChangeOnSegment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a property on segments that will tell us whether or not a new show style variant is defined by the segment. This is to be used in Sofie Server so we can reingest based on the property.
This is used in the Sofie Server PR: https://github.com/tv2/sofie-server/pull/169