chore: fix Android SoLoader occasional crash on app re-install #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ravikp I was able to reproduce it crashing on Nokia 6.1 Plus(Android 10, BLE5.0) by installing various old and new APKs and the app didn't crash once the newer APK generated from this branch was installed after previously installed APK was crashing. This scenario proves that this changeset fixes this issue for this platform combination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix ?
tl; dr: Fixes a possible crash on android install which happens on Android 9, 10 & 11.
detailed: At times when the Android app with some app-data is upgraded the app fails to load with these Exceptions and crashes each time the app is opened on device. These logs have are captured android-onlaunch-crash.txt for this bug.
ref: facebook/SoLoader#77
fixes: mosip#622