Skip to content

Commit

Permalink
Merge pull request #1935 from avdv/windows-build-event-upload
Browse files Browse the repository at this point in the history
Retry uploading build events more often
  • Loading branch information
mergify[bot] authored Aug 16, 2023
2 parents 1bd3c46 + 13312bf commit 347ccfe
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 1 deletion.
6 changes: 5 additions & 1 deletion .bazelrc.common
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@ build:ci-common --repository_cache=~/repo-cache/
build:ci-common --experimental_repository_cache_hardlinks

# Use a remote cache during CI
build:ci-windows-bindist --bes_upload_mode=wait_for_upload_complete --bes_timeout=60s
build:ci-windows-bindist --bes_upload_mode=wait_for_upload_complete --bes_timeout=600s
# On Github CI for Windows, we see intermittent connection failures to BuildBuddy
# (see https://github.com/buildbuddy-io/buildbuddy/issues/4467)
# increase the retries as a workaround.
build:ci-windows-bindist --experimental_build_event_upload_max_retries=256
build:remote-cache --remote_cache=grpcs://remote.buildbuddy.io
build:ci-common --remote_timeout=3600
# Avoid failures of the form `deadline exceeded after 14999958197ns DEADLINE_EXCEEDED`.
Expand Down
22 changes: 22 additions & 0 deletions .github/workflows/workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -199,3 +199,25 @@ jobs:
# NOTE keep in sync with tests/RunTests.hs
bazel run @stackage-pinning-test-unpinned//:pin
bazel build @stackage-pinning-test//:hspec
- name: Collect Logs
id: collect_logs
if: failure()
shell: bash
run: |
mkdir -p logs
if [[ ${{ matrix.module }} == 'rules_haskell_tests' ]]; then
dir=rules_haskell_tests
else
dir=.
fi
export PATH=$HOME/bazel:$PATH
base=$( cd "$dir" ; bazel info output_base )
find "$base" -mindepth 1 -maxdepth 1 -name "java*.log.*" -print0 | xargs -0rI % cp % logs/
- name: Upload Logs
if: ${{ failure() && steps.collect_logs.conclusion == 'success' }}
uses: actions/upload-artifact@v3
with:
name: Logs ${{ matrix.os }} ${{ matrix.module }} ${{ matrix.bzlmod }}
path: logs

0 comments on commit 347ccfe

Please sign in to comment.