[Twig 4] Add PHPUnit as dev dependency

[ruudk]

This makes it easier to run the tests locally.

I understand we didn't do this previously (Twig 3) because of symfony/simple-phpunit. But that is now removed in Twig 4, so maybe we can do this as well?

[fabpot]

@ruudk That works for me. We used to have PHPunit 11.3. Here, you're suggesting to bump to 11.5, but tests don't pass, can you have a look?

[ruudk]

Reported problem upstream:

• Code inside eval triggers deprecation, results in ExcludeList::isExcluded(): Argument #1 ($file) must be of type string, null given sebastianbergmann/phpunit#6043

I'll report back here when it's resolved.

[sebastianbergmann]

you're suggesting to bump to 11.5

I am also interested in why you propose to use a development version of PHPUnit.

[ruudk]

@sebastianbergmann I did not do this on purpose. I ran composer require phpunit/phpunit --dev and it picked ^11.5. Even when I manually choose ^11.4 is still installs the dev version.

I think we need to change this:

Twig/composer.json

Line 8 in c0689e3

"minimum-stability": "dev",

I was unaware of this setting.

[ruudk]

PR is ready for review now.

[stof]

using dev stability for our dependencies was done on purpose. You should use phpunit/phpunit": "^11.4@stable" to override it only for phpunit instead.

[ruudk]

Is it really needed? Looking at the dependencies:

Twig/composer.json

Lines 26 to 35 in c192cbf

	"require": {
	"php": ">=8.2",
	"symfony/deprecation-contracts": "^2.5|^3",
	"symfony/polyfill-mbstring": "^1.3",
	"symfony/polyfill-ctype": "^1.8"
	},
	"require-dev": {
	"psr/container": "^1.0|^2.0",
	"phpstan/phpstan": "^2.0"
	},

[ruudk]

Btw, the same thing happened when @VincentLanglet added PHPStan. It was installing the dev version without anybody noticing it.

[VincentLanglet]

"phpstan/phpstan": "^2.0@stable"

should be preferred too then

[fabpot]

Thank you @ruudk.