Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uneeded property on Error #4596

Closed
wants to merge 1 commit into from
Closed

Remove uneeded property on Error #4596

wants to merge 1 commit into from

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Feb 22, 2025

No description provided.

@stof
Copy link
Member

stof commented Feb 23, 2025

IIRC, this was done this way to override the native line property only when we can also override the file, to avoid having a line number not corresponding to the file being mentioned in the stack trace.

@fabpot
Copy link
Contributor Author

fabpot commented Feb 26, 2025

Right, see #4598

@fabpot fabpot closed this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabpot @stof