From e77b081788773a46cc23df133950b71da87055ad Mon Sep 17 00:00:00 2001
From: Valdemar Erk <valdemar@erk.dev>
Date: Tue, 28 Jan 2025 16:04:11 +0100
Subject: [PATCH 1/2] feat(model): Add various From implementations for
 CommandOptionValue

Closes #2403
---
 .../interaction/application_command/option.rs | 54 +++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/twilight-model/src/application/interaction/application_command/option.rs b/twilight-model/src/application/interaction/application_command/option.rs
index 2060b8cc3b2..42a9c9f841a 100644
--- a/twilight-model/src/application/interaction/application_command/option.rs
+++ b/twilight-model/src/application/interaction/application_command/option.rs
@@ -360,6 +360,60 @@ pub enum CommandOptionValue {
     User(Id<UserMarker>),
 }
 
+impl From<Id<AttachmentMarker>> for CommandOptionValue {
+    fn from(value: Id<AttachmentMarker>) -> Self {
+        CommandOptionValue::Attachment(value)
+    }
+}
+
+impl From<bool> for CommandOptionValue {
+    fn from(value: bool) -> Self {
+        CommandOptionValue::Boolean(value)
+    }
+}
+
+impl From<Id<ChannelMarker>> for CommandOptionValue {
+    fn from(value: Id<ChannelMarker>) -> Self {
+        CommandOptionValue::Channel(value)
+    }
+}
+
+impl From<i64> for CommandOptionValue {
+    fn from(value: i64) -> Self {
+        CommandOptionValue::Integer(value)
+    }
+}
+
+impl From<Id<GenericMarker>> for CommandOptionValue {
+    fn from(value: Id<GenericMarker>) -> Self {
+        CommandOptionValue::Mentionable(value)
+    }
+}
+
+impl From<f64> for CommandOptionValue {
+    fn from(value: f64) -> Self {
+        CommandOptionValue::Number(value)
+    }
+}
+
+impl From<Id<RoleMarker>> for CommandOptionValue {
+    fn from(value: Id<RoleMarker>) -> Self {
+        CommandOptionValue::Role(value)
+    }
+}
+
+impl From<String> for CommandOptionValue {
+    fn from(value: String) -> Self {
+        CommandOptionValue::String(value)
+    }
+}
+
+impl From<Id<UserMarker>> for CommandOptionValue {
+    fn from(value: Id<UserMarker>) -> Self {
+        CommandOptionValue::User(value)
+    }
+}
+
 impl CommandOptionValue {
     pub const fn kind(&self) -> CommandOptionType {
         match self {

From 018f410e5cd4162f4e84c5813852faa57c3e9bf4 Mon Sep 17 00:00:00 2001
From: Valdemar Erk <valdemar@erk.dev>
Date: Wed, 5 Feb 2025 16:53:56 +0100
Subject: [PATCH 2/2] Remove Id<GenericMarker> impl.

---
 .../application/interaction/application_command/option.rs   | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/twilight-model/src/application/interaction/application_command/option.rs b/twilight-model/src/application/interaction/application_command/option.rs
index 42a9c9f841a..05daf28757f 100644
--- a/twilight-model/src/application/interaction/application_command/option.rs
+++ b/twilight-model/src/application/interaction/application_command/option.rs
@@ -384,12 +384,6 @@ impl From<i64> for CommandOptionValue {
     }
 }
 
-impl From<Id<GenericMarker>> for CommandOptionValue {
-    fn from(value: Id<GenericMarker>) -> Self {
-        CommandOptionValue::Mentionable(value)
-    }
-}
-
 impl From<f64> for CommandOptionValue {
     fn from(value: f64) -> Self {
         CommandOptionValue::Number(value)