Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove forward-message-sendgrid, forward-message-sparkpost and remove got devDep #574

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Oct 18, 2024

Description

removes forward-message-sendgrid and forward-message-sparkpost since they're relatively unmaintained and from a pass over of them both, look like they need to be fully rewritten from scratch to not use an extremely old version of got or need to be converted to ESM to continue using got.

Checklist

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

Related issues

N/A

Copy link
Contributor

@pkamp3 pkamp3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, maintainability.

@bnb bnb merged commit baba6a6 into main Nov 13, 2024
2 checks passed
@bnb bnb deleted the bnb/remove-some-templates branch November 13, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants