Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lib/twingly/version.rb #78

Open
dentarg opened this issue May 17, 2018 · 3 comments
Open

Add lib/twingly/version.rb #78

dentarg opened this issue May 17, 2018 · 3 comments

Comments

@dentarg
Copy link
Contributor

dentarg commented May 17, 2018

Doesn't look like we keep this file up to date:

module Twingly
module LiveFeed
VERSION = "5.0.1"
end
end

I don't think this file has any real purpose.

Let's add lib/twingly/version.rb (see comment below).

Update README when doing this: https://github.com/twingly/twingly-search-api-ruby#release

@dentarg dentarg changed the title Remove ib/twingly/livefeed/version.rb? Remove lib/twingly/{livefeed,search}/version.rb, add lib/twingly/version.rb May 17, 2018
@dentarg dentarg removed the question label May 17, 2018
@dentarg
Copy link
Contributor Author

dentarg commented May 17, 2018

Maybe we need to keep lib/twingly/{livefeed,search}/version.rb around, to not break stuff, but they could get the value from lib/twingly/version.rb.

@dentarg dentarg changed the title Remove lib/twingly/{livefeed,search}/version.rb, add lib/twingly/version.rb Add lib/twingly/version.rb May 17, 2018
@walro
Copy link
Contributor

walro commented May 17, 2018

Maybe we need to keep lib/twingly/{livefeed,search}/version.rb around, to not break stuff, but they could get the value from lib/twingly/version.rb.

Yeah, sounds smart

@jage
Copy link
Contributor

jage commented Apr 3, 2019

What should the module name be, for the common version?

Now we have:

  • Twingly::Search::VERSION
  • Twingly::LiveFeed::VERSION

I don't think we should add Twingly::VERSION, so we need a new name.

Some ideas:

  • Twingly::BlogApiClient::VERSION
  • Twingly::Search::VERSION (I.e. LiveFeed will just use the Search version as the gem is still named search, no new file at all)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants