Skip to content

Commit

Permalink
Merge pull request #724 from pracucci/clarify-overhead-timeout
Browse files Browse the repository at this point in the history
Clarify kgo.RequestTimeoutOverhead() documentation
  • Loading branch information
twmb authored May 26, 2024
2 parents 67f45f3 + cf530a1 commit 11b6731
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/kgo/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ func WithLogger(l Logger) Opt {
// RequestTimeoutOverhead uses the given time as overhead while deadlining
// requests, overriding the default overhead of 10s.
//
// For most requests, the overhead will simply be this timeout. However, for
// For most requests, the timeout is set to the overhead. However, for
// any request with a TimeoutMillis field, the overhead is added on top of the
// request's TimeoutMillis. This ensures that we give Kafka enough time to
// actually process the request given the timeout, while still having a
Expand Down

0 comments on commit 11b6731

Please sign in to comment.