We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompressionCoded.WithLevel casts its argument to byte and maxes out at 127. -
franz-go/pkg/kgo/compression.go
Line 71 in a5f2b71
However, LZ4 compression levels are much larger than that - https://github.com/pierrec/lz4/blob/v4/options.go#L155 - they are defined as 0, 512, 1024, ... , 131072.
Specifying LZ4 compression level in franz-go therefore will always result in the default.
The text was updated successfully, but these errors were encountered:
I think this should be a relatively small fix by converting that internally to an int
Sorry, something went wrong.
i agree. i can take a stab at this today.
#781
Successfully merging a pull request may close this issue.
CompressionCoded.WithLevel casts its argument to byte and maxes out at 127. -
franz-go/pkg/kgo/compression.go
Line 71 in a5f2b71
However, LZ4 compression levels are much larger than that - https://github.com/pierrec/lz4/blob/v4/options.go#L155 - they are defined as 0, 512, 1024, ... , 131072.
Specifying LZ4 compression level in franz-go therefore will always result in the default.
The text was updated successfully, but these errors were encountered: