MySQL Fatal Error

[connorhsm]

Fitness Server causing fatal error:

Fatal error: Database query failed:
SELECT life_id, life_player_id, name, age, display_id, relation_name, offspring.score_change, offspring.death_time, TIMESTAMPDIFF( SECOND, offspring.death_time, CURRENT_TIMESTAMP ) as died_sec_ago FROM fitnessServer_offspring AS offspring INNER JOIN fitnessServer_lives AS lives ON offspring.life_id = lives.id WHERE offspring.player_id = AND offspring.death_time > DATE_SUB( NOW(), INTERVAL 168 HOUR ) ORDER BY offspring.death_time DESC LIMIT 20;

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'AND offspring.death_time > DATE_SUB( NOW(), INTERVAL 168 HOUR ) ORDER BY offspri' at line 1

Suspected code/query causing issues:

OneLifeWeb/web/public/fitnessServer/server.php

Lines 2132 to 2141 in 567951a

	$query = "SELECT life_id, life_player_id, name, age, display_id, relation_name, ".
	"offspring.score_change, offspring.death_time, ".
	"TIMESTAMPDIFF( SECOND, offspring.death_time, CURRENT_TIMESTAMP ) as died_sec_ago ".
	"FROM $tableNamePrefix"."offspring AS offspring ".
	"INNER JOIN $tableNamePrefix"."lives AS lives ".
	"ON offspring.life_id = lives.id ".
	"WHERE offspring.player_id = $id ".
	"AND offspring.death_time > DATE_SUB( NOW(), INTERVAL $scoreRollingWindow HOUR ) ".
	"ORDER BY offspring.death_time DESC ".
	"LIMIT $maxOffspringToShowPlayer;";

[connorhsm]

@risvh I'm having some trouble figuring what causes this error.
I believe the query I've found in server.php is executed when displaying the Genes page on the client, but can't reproduce the error myself.
I also can't spot any immediate errors in the query, apart from some formatting differences in the PHP.

Are you able to offer any help here?

[connorhsm]

Although
...WHERE offspring.player_id = ?? AND offspring.death_time >...
It looks as if there might be a missing ID in the query, where I have added the ??.

[risvh]

Yes there should be an ID there "WHERE offspring.player_id = $id ".
and further above $id = fs_mysqli_result( $result, 0, "player_id" );
which in turn comes from the offspring table

OneLifeWeb/web/public/fitnessServer/server.php

Lines 2116 to 2128 in 567951a

	$query = "SELECT email, player_id, round(sum(score_change), 4) as score, max(death_time) as last_death_time ".
	"FROM $tableNamePrefix"."offspring as offspring ".
	"INNER JOIN $tableNamePrefix"."users as users ".
	"ON offspring.player_id = users.id ".
	"WHERE death_time > DATE_SUB( NOW(), INTERVAL $scoreRollingWindow HOUR ) ".
	"AND email = '$email' ".
	"GROUP BY player_id ".
	"ORDER BY score DESC, last_death_time DESC;";
	$result = fs_queryDatabase( $query );
	$score = fs_mysqli_result( $result, 0, "score" );
	$id = fs_mysqli_result( $result, 0, "player_id" );