Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Config output_dir does not behave as expected #1880

Open
jprokos26 opened this issue Feb 3, 2023 · 2 comments
Open

[Feature]: Config output_dir does not behave as expected #1880

jprokos26 opened this issue Feb 3, 2023 · 2 comments

Comments

@jprokos26
Copy link
Contributor

jprokos26 commented Feb 3, 2023

  1. When supplying a value such as INTL as output_dir, armory outputs the results to ~/.armory/outputs/INTL_<generated_name>/… as opposed to what would be expected ~/.armory/outputs/INTL/<generated_name>/…
  2. When supplying an absolute path to output_dir it throws a Permission denied error, if armory should still throw an error here, it might be useful to update the error message to inform the user that output_dir should be a relative path.

NOTE: Can supply INTL/ as the output_dir to have it output in that folder as a no-code-change fix

@christopherwoodall
Copy link
Contributor

christopherwoodall commented Feb 7, 2023

There is a lot of directory management/creation logic happening in armory/scenarios/scenario.py and also armory/paths.py.

I like the idea of consolidating all of the directory creation logic inside paths.py but am curious about what others think.

@swsuggs
Copy link
Contributor

swsuggs commented Jul 10, 2023

Related to #1329. I agree if the output dir and filename values are supplied, Armory should not append the timestamps and IDs. @christopherwoodall Feel free to consolidate the logic in a way that makes sense to you if you are still interested in taking care of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants