Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: custom style prompt #26

Open
rsandx opened this issue Feb 26, 2024 · 2 comments
Open

Feature request: custom style prompt #26

rsandx opened this issue Feb 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@rsandx
Copy link

rsandx commented Feb 26, 2024

The included styles in this node are pretty good, but there're actually endless styles, it's impossible to include all, and if you include more the list will become too long to use easily. I propose to add a custom style prompt input, so that user can use an artist style, such as "breathtaking {prompt} by Anna Dittmann," weights can also be easily added by user. This should work as long as the simple format is followed, i.e., the style contains a {prompt} placeholder, which is simple to validate. When there're values in both the selected style and custom style, the custom one should take precedence. Please consider adding this feature., which will make this node the most powerful prompt styler.

@twri
Copy link
Owner

twri commented Feb 27, 2024

It's been requested before in some form or another. See #18 #14. It only loads files named .json so splitting them into different files and just renaming them will prevent them from being loaded. Not the most elegant solution but it works.

Multiselect and features like this has to be implemented client side since the GUI only updates when you queue something. And then it would probably be better to put a category or tags that you could filter for in the JSON.

I probably won't put the effort into doing something complex out of something that is simple, sorry. I think it would be better to build a frontend for ComfyUI that handles this instead like StableSwarmUI.

@twri twri added the enhancement New feature or request label Feb 27, 2024
@rsandx
Copy link
Author

rsandx commented Feb 27, 2024

@twri Thanks for your excellent work! What I proposed is not multiselect, but a new input field that takes a plain string, using the same template as other styles you have in the JSON files, such as "breathtaking {prompt} by Anna Dittmann," Although it's up to user to enter the style text, you can do a simple validation to make sure a {prompt} placeholder to be present so that the text can be used as a style by your node, This should be a simple addition, but makes your node extendable with endless styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants