Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop fs-extra dependency to avoid memory leak on jest tests #68

Closed
sibelius opened this issue Aug 1, 2018 · 3 comments
Closed

drop fs-extra dependency to avoid memory leak on jest tests #68

sibelius opened this issue Aug 1, 2018 · 3 comments

Comments

@sibelius
Copy link

sibelius commented Aug 1, 2018

it looks like fs-extra depends on graceful-fs that is causing jest to leak

check this jestjs/jest#6738
and isaacs/node-graceful-fs#102

can we avoid using fs-extra in this module?
@nodkz nodkz closed this as completed in 27333bb Aug 2, 2018
@nodkz
Copy link
Collaborator

nodkz commented Aug 2, 2018

Сool research! Thanks!

@nodkz
Copy link
Collaborator

nodkz commented Aug 2, 2018

🎉 This issue has been resolved in version 1.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@sibelius
Copy link
Author

sibelius commented Aug 2, 2018

tks, our tests are still leaking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nodkz @sibelius