Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct way to package library #5

Open
leonardehrenfried opened this issue Apr 20, 2020 · 0 comments
Open

Correct way to package library #5

leonardehrenfried opened this issue Apr 20, 2020 · 0 comments

Comments

@leonardehrenfried
Copy link

I was trying to use the newest version of this library in my project but it seems that the UMD packaging doesn't work with webpack. I've received the following error:

WARNING in ./node_modules/lehrenfried-simple-opening-hours/dist/simple-opening-hours.js 3:24-31
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted

When I set the tsc packaging to commonjs it works. Not sure if that is the right settings though.

Besides, the examples work with neither packaging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant