Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andorra missing its 2-character country code #34

Open
VizualAbstract opened this issue May 29, 2020 · 2 comments
Open

Andorra missing its 2-character country code #34

VizualAbstract opened this issue May 29, 2020 · 2 comments

Comments

@VizualAbstract
Copy link

VizualAbstract commented May 29, 2020

It looks like in the recent update (thank you so much!) Andorra was missing its 2-digit country code.

This PR aims to restore that: #33

Screen Shot 2020-05-29 at 3 14 41 PM

@ubaldop
Copy link
Owner

ubaldop commented May 31, 2020

Hi @VizualAbstract thanks for proposing this change. Actually because of #27 I had to do a workaround for Andorra flag.
As you may notice here you can still use ad when declaring the flag, but on component side it is translated to f-andorra CSS class.

@ubaldop
Copy link
Owner

ubaldop commented May 31, 2020

However I leave your proposal still opened here because instead of restoring "f-ad" it could be better of get rid of "f-andorra" CSS class leaving only "f-and" instead.
So, referring to this, it could become:

country = (country === 'ad') ? 'and' : country

would you mind to align your PR with this improvement?

Doing so could make the component slightly lighter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants