moved to env vars

ubc-biztech · Mar 1, 2024 · 387d270 · 387d270
1 parent 9559735
commit 387d270
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 6 deletions.
diff --git a/.github/workflows/deploy-prod.yml b/.github/workflows/deploy-prod.yml
@@ -41,6 +41,8 @@ jobs:
       STRIPE_DEV_ENDPOINT: ${{ secrets.STRIPE_DEV_ENDPOINT }}
       STRIPE_PROD_CANCEL: ${{ secrets.STRIPE_PROD_CANCEL }}
       STRIPE_PROD_ENDPOINT: ${{ secrets.STRIPE_PROD_ENDPOINT }}
+      STRIPE_PROD_KEY: ${{ secrets.STRIPE_PROD_KEY}}
+      STRIPE_DEV_KEY: ${{ secrets.STRIPE_DEV_KEY}}
 
      # TODO: deploy all to production
      run: |

diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
@@ -43,6 +43,8 @@ jobs:
       STRIPE_DEV_ENDPOINT: ${{ secrets.STRIPE_DEV_ENDPOINT }}
       STRIPE_PROD_CANCEL: ${{ secrets.STRIPE_PROD_CANCEL }}
       STRIPE_PROD_ENDPOINT: ${{ secrets.STRIPE_PROD_ENDPOINT }}
+      STRIPE_PROD_KEY: ${{ secrets.STRIPE_PROD_KEY}}
+      STRIPE_DEV_KEY: ${{ secrets.STRIPE_DEV_KEY}}
      run: |
       cd services
       for DIR in *; do
@@ -51,6 +53,8 @@ jobs:
          --STRIPE_DEV_ENDPOINT ${{ secrets.STRIPE_DEV_ENDPOINT }} \
          --STRIPE_PROD_CANCEL ${{ secrets.STRIPE_PROD_CANCEL }} \
          --STRIPE_PROD_ENDPOINT ${{ secrets.STRIPE_PROD_ENDPOINT }} \
+         --STRIPE_PROD_KEY ${{ secrets.STRIPE_PROD_KEY }} \
+         --STRIPE_DEV_KEY ${{ secrets.STRIPE_DEV_KEY }} \
          && cd ..) & done; wait
 
    - name: 'Deploy Prod'
@@ -64,6 +68,8 @@ jobs:
       STRIPE_DEV_ENDPOINT: ${{ secrets.STRIPE_DEV_ENDPOINT }}
       STRIPE_PROD_CANCEL: ${{ secrets.STRIPE_PROD_CANCEL }}
       STRIPE_PROD_ENDPOINT: ${{ secrets.STRIPE_PROD_ENDPOINT }}
+      STRIPE_PROD_KEY: ${{ secrets.STRIPE_PROD_KEY}}
+      STRIPE_DEV_KEY: ${{ secrets.STRIPE_DEV_KEY}}
      run: |
       cd services
       for DIR in *; do
@@ -72,4 +78,6 @@ jobs:
           --STRIPE_DEV_ENDPOINT ${{ secrets.STRIPE_DEV_ENDPOINT }} \
           --STRIPE_PROD_CANCEL ${{ secrets.STRIPE_PROD_CANCEL }} \
           --STRIPE_PROD_ENDPOINT ${{ secrets.STRIPE_PROD_ENDPOINT }} \
+          --STRIPE_PROD_KEY ${{ secrets.STRIPE_PROD_KEY }} \
+          --STRIPE_DEV_KEY ${{ secrets.STRIPE_DEV_KEY }} \
           && cd ..) & done; wait
diff --git a/services/payments/handler.js b/services/payments/handler.js
@@ -15,18 +15,19 @@ const {
 } = require("../../constants/tables");
 const stripe = require("stripe")(
   process.env.ENVIRONMENT === "PROD"
-    ? "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"
-    : "sk_test_51KOxOlBAxwbCreS7JRQtvZCnCgLmn8tjK7WPHDGjpw0s4vfVHLwbcrZZvQLmd5cY7zKRIsfj3pnEDDHTy3G81Tuf00v9ygIBrC"
+    ? process.env.STRIPE_PROD_KEY
+    : process.env.STRIPE_DEV_KEY
 );
+
 // endpoint secret - different for each webhook
 const endpointSecret =
   process.env.ENVIRONMENT === "PROD"
-    ? "whsec_IOXyPRmf3bsliM3PfWXFhvkmHGeSMekf"
-    : "whsec_TYSFr29HQ4bIPu649lgkxOrlPjrDOe2l";
+    ? process.env.STRIPE_PROD_ENDPOINT
+    : process.env.STRIPE_DEV_ENDPOINT;
 const cancelSecret =
   process.env.ENVIRONMENT === "PROD"
-    ? "whsec_aX8umTlvtlmg0H2KCGDc9Er9Iej6TP8D"
-    : "whsec_N81csvvnTAqicFpuV5o9JQfx6McImtPR";
+    ? process.env.STRIPE_PROD_CANCEL
+    : process.env.STRIPE_DEV_CANCEL;
 
 // Creates the member here
 export const webhook = async (event, ctx, callback) => {

diff --git a/services/payments/serverless.yml b/services/payments/serverless.yml
@@ -22,6 +22,8 @@ provider:
     STRIPE_DEV_ENDPOINT: ${opt:STRIPE_DEV_ENDPOINT}
     STRIPE_PROD_CANCEL: ${opt:STRIPE_PROD_CANCEL}
     STRIPE_PROD_ENDPOINT: ${opt:STRIPE_PROD_ENDPOINT}
+    STRIPE_PROD_KEY: ${opt:STRIPE_PROD_KEY}
+    STRIPE_DEV_KEY: ${opt:STRIPE_DEV_KEY}
   apiGateway:
     restApiId: !ImportValue ${self:provider.stage}-ExtApiGatewayRestApiId
     restApiRootResourceId: !ImportValue ${self:provider.stage}-ExtApiGatewayRestApiRootResourceId